Open
Conversation
Contributor
|
hey - can you look at the conflicts? |
guillomovitch
force-pushed
the
sign-multiple-files
branch
from
8bc522a to
631f3c1
Compare
guillomovitch
force-pushed
the
sign-multiple-files
branch
from
c54f8a5 to
c03ccb0
Compare
Author
|
Done, here is a cleaner version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When signing multiple files with the same key/certificate pair (for instance, the 8132 files resulting from splitting edugain metadata into mdq ready-to-serve individual metadata files), calling xmlsec.sign() once par file results in a waste of resources, as the key and the certificate are read everytime.
This PR tries to address this issue with a Signer object, instantiated once, used multiple times, such as:
signer = xmlsec.Signer(keyspec, certspec)
output = signer.sign(input)
I'm not a Python expert, so the code can certainly get improved, but provided tests ensure at least it works as expected.